This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
PPM-338 Move UCI configuration to Agent DB #1590
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenvor
force-pushed
the
feature/PPM-338-move-uci-config-to-agent-db
branch
3 times, most recently
from
a6aef83 to
1e63f24
Compare
orenvor
requested review from
adam1985d,
arnout,
kantera800,
mariomaz,
morantr,
rmelotte,
tomereli and
vitalybu
as code owners
orenvor
force-pushed
the
feature/PPM-338-move-uci-config-to-agent-db
branch
2 times, most recently
from
45ee140 to
28a3225
Compare
Move front radio configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of front radio settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move back radio configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of back radio settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "mem_only_psk" configuration of back radio from "sPlatformSettings" struct to the AgentDB. Replace the use of "mem_only_psk" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "backhaul_max_vaps" configuration of back radio from "sPlatformSettings" struct to the AgentDB. Replace the use of "backhaul_max_vaps" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "backhaul_network_enabled" configuration of back radio from "sPlatformSettings" struct to the AgentDB. Replace the use of "backhaul_network_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "backhaul_preferred_radio_band" configuration of back radio from "sPlatformSettings" struct to the AgentDB. Replace the use of "backhaul_preferred_radio_band" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "operating_mode" configuration of from "sPlatformSettings" struct to the AgentDB. Replace the use of "operating_mode" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "management_mode" configuration of from "sPlatformSettings" struct to the AgentDB. Replace the use of "management_mode" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "certification_mode" configuration of from "sPlatformSettings" struct to the AgentDB. Replace the use of "certification_mode" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "stop_on_failure_attempts" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "stop_on_failure_attempts" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "client_band_steering_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "client_band_steering_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "client_optimal_path_roaming_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "client_optimal_path_roaming_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "dfs_reentry_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "dfs_reentry_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "client_optimal_path_roaming_prefer_signal_strength_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "client_optimal_path_roaming_prefer_signal_strength_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "client_11k_roaming_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "client_11k_roaming_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "load_balancing_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "load_balancing_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "service_fairness_enabled" configuration from "sPlatformSettings" struct to the AgentDB. Replace the use of "service_fairness_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "rdkb_extensions_enabled" configuration of back radio from "sPlatformSettings" struct to the AgentDB. Replace the use of "rdkb_extensions_enabled" settings on the Agent thread to the one on the AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Remove unused "onboarding" configuration from "sPlatformSettings" struct. Replace the use of "onboarding" with false value. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Remove of unused fields from sPlatformSettings struct. Those fields have been moved to the Agent_DB and there for no longer needed as part of a beerocks massage. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Remove "platform_settings" local variable from son_slave_thread. Replace the use of "platform_settings" to the settings in AgentDB. Removing of the config from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Move "wlan_settings" configuration from son_slave_thread local variable to the AgentDB. Currently son_slave receive "wlan_settings" from platform_manager using "PLATFORM_SON_SLAVE_REGISTER_REQUEST/RESPONSE" messages, and save the settings in a local variable. This transfer will be replaced by the use of agent_db to pass and store "wlan_settings". Removing of "sWlanSettings" from the tlvf will take place on future commit. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
Signed-off-by: Oren Vormaser <[email protected]>
Remove of unused fields: sPlatformSettings and wlan_settings from PLATFORM_SON_SLAVE_REGISTER_RESPONSE message. Those fields have been moved to the Agent_DB and there for no longer needed as part of this beerocks massage. PPM-338 Signed-off-by: Oren Vormaser <[email protected]>
orenvor
force-pushed
the
feature/PPM-338-move-uci-config-to-agent-db
branch
from
28a3225 to
9c450e9
Compare
mariomaz
approved these changes
Aug 14, 2020
|
|
||
| char ssid[beerocks::message::WIFI_SSID_MAX_LENGTH]; | ||
| char pass[beerocks::message::WIFI_PASS_MAX_LENGTH]; | ||
| char security_type[beerocks::message::WIFI_SECURITY_TYPE_MAX_LENGTH]; |
There was a problem hiding this comment.
Please add doxygen documentation
|
|
||
| char ssid[beerocks::message::WIFI_SSID_MAX_LENGTH]; | ||
| char pass[beerocks::message::WIFI_PASS_MAX_LENGTH]; | ||
| char security_type[beerocks::message::WIFI_SECURITY_TYPE_MAX_LENGTH]; |
There was a problem hiding this comment.
Please add doxygen documentation
| @@ -160,6 +160,7 @@ class slave_thread : public beerocks::socket_thread { | |||
| std::string backhaul_manager_uds; | |||
| std::string platform_manager_uds; | |||
| sSlaveConfig config; | |||
| beerocks_message::sWlanSettings wlan_settings; // from platform manager // | |||
There was a problem hiding this comment.
Please add proper doxygen documentation
| @@ -208,7 +208,7 @@ static bool fill_platform_settings( | |||
| msg->platform_settings().certification_mode = uint8_t(platform_common_conf.certification_mode); | |||
| msg->platform_settings().stop_on_failure_attempts = | |||
| uint8_t(platform_common_conf.stop_on_failure_attempts); | |||
| msg->platform_settings().backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps); | |||
| db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps); | |||
There was a problem hiding this comment.
Suggested change
| db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps); | |
| db->device_conf.back_radio.backhaul_max_vaps = static_cast<uint8_t>(platform_common_conf.backhaul_max_vaps); |
This PR seems like a good opportunity to replace all these C style casts with the preferred C++ style casts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves agent configuration from the local "sPlatformSettings" struct to the AgentDB.
Preparation for unified agent task.